Remove an optimization to catch all messages when they are not ordered#21
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 18599667092Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Ma11hewThomas
approved these changes
Nov 1, 2025
Contributor
|
Thanks for the fix @jmaitrehenry! I'm happy with this solution, the original break was well intentioned but with Go's speed, I'm not worried about performance with large test suites. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a bug with the parallelization of our tests, we could receive message from other tests in the middle of current tests and the current implementation of the reporter doesn't support that.
For fixing it, we need to remove break in the loop. For large codebase, it could be an issue, the other solutions is to use a map where the key will be the packageName and testName. What do you think?